RFR 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Sun Oct 20 20:09:27 UTC 2013


>
>> Hi Alex,
>>
>> This looks good.
>>
>> Hi Sherman, Alan,
>>
>> Could one of you review this, please
>>
> The "-n" options seems okay but I wonder if there has any thought 
> given to having an option on jarsigner to normalize it before signing?

The PM requirement was for jar, in that when a jar is created it should
be ready to go.

>
> On the patch itself then I think it needs to be cleaned up before 
> pushing it. From a quick look:
>
> - It's using a raw type for the packer properties, should be 
> Map<String, String>
> - Is any reason not to use try-with-resources?
> - I assume the catching of Exception in createTemporaryFile should be 
> IOException|SecurityException
> - Is the @test tag in the test right?
> - The test appears to extract jfr.jar but I don't think we can assume 
> this exists
> - Some of the jar tests use sun.tools.jar.Main and this might be 
> useful here
> One other thing, Mathias's mail to jdk8-dev [1] asks for changes that 
> require translation to be in the master no longer than 10/24. Does the 
> update to jar.properties count?

Yes, it does, as there are properties changes and man page changes.
We will need to special case this somehow.

Kumar

>
> -Alan
>
> [1] 
> http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-October/003443.html




More information about the core-libs-dev mailing list