RFR: 8004912: Repeating annotations - getAnnotationsByType is not working as expected

Andreas Lundblad andreas.lundblad at oracle.com
Tue Oct 22 10:33:31 UTC 2013


On Tue 22 Oct 2013 12:21:36 PM CEST, Joel Borggrén-Franck wrote:
> Hi Andreas,
>
> A few nits:
>
> Class.java:
>
>   import java.util.Collection;
> +import java.util.Collections;
>   import java.util.HashSet;
>
> unused import.

Right. Thanks.


> AnnotationSupport.java:
>
> +    /**
> +     * Equivalent to calling {@code getDirectlyAndIndirectlyPresentAnnotations(
> +     * annotations, annoClass, false)}.
> +     */
>
> I think it is equivalent to annotations, annoClass, true

Absolutely. Good catch.


> Otherwise looks good. I can sponsor this fix.
>
> cheers
> /Joel
>

Thanks Joel.

-- Andreas



More information about the core-libs-dev mailing list