Please Review javadoc fixes 8026982

Joe Darcy joe.darcy at oracle.com
Tue Oct 22 19:15:22 UTC 2013


Hi Roger,

On 10/22/2013 11:53 AM, roger riggs wrote:
> Please review more javadoc cleanup to satisfy javadoc -Xlint.
> The changes remove <p> markup where it is invalid or unnecessary
> in packages java. io, lang, net, nio, rmi, security, text, and util.
> (this is a relatively low priority cleanup).
>
> Webrev:
>
> http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026982/
>
> Thanks, Roger
>

For several comments in DataInput.java like

@@ -316,7 +316,7 @@
       * be the second byte. The value
       * returned
       * is:
-     * <p><pre><code>(short)((a << 8) | (b & 0xff))
+     * <pre><code>(short)((a << 8) | (b & 0xff))
       * </code></pre>
       * This method
       * is suitable for reading the bytes written

it would be better to use

     {@code (short)((a << 8) | (b & 0xff))}

I assume most of the changes in 
src/share/classes/java/security/MessageDigest.java are whitespace.

Looks good to go back with or without the additional {@code usage} 
modulo any merge that needs to be done (I fixed a few of the doclint 
issues in the just-pushed 8027062).

Thanks,

-Joe



More information about the core-libs-dev mailing list