RFR 8020802: Need an ability to create jar files that are invariant to the pack200 packing/unpacking
Alan Bateman
Alan.Bateman at oracle.com
Wed Oct 23 16:15:51 UTC 2013
On 22/10/2013 23:56, Alexander Zuev wrote:
> Alan,
>
> i guess you're right, i have updated code to use the same method
> with fallback for creation .pack temporary file.
> New webrev can be found at
> http://cr.openjdk.java.net/~kizune/8020802/webrev.05
>
> /Alex
>
Thanks, this is better. A small suggestion (I think I mentioned in one
of the early mails) is that you could use try-with-resources for the
pack file, not critical, just a suggestion. Also a minor nit on line
217, missing space in "if(".
-Alan.
More information about the core-libs-dev
mailing list