RFR (JAXP enableExtensionFunctions): 8004476 XSLT Extension Functions Don't Work in WebStart

[Lance Andersen - Oracle]

looks OK joe
On Oct 23, 2013, at 3:42 PM, huizhe wang wrote:

> Hi Daniel,
> 
> Thanks for the review and the detailed list. I've updated the webrev:
> 
> http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/
> 
> Thanks,
> Joe
> 
> On 10/23/2013 11:25 AM, Daniel Fuchs wrote:
>> Hi Joe,
>> 
>> I believe all the private FeatureManager could be declared
>> final since asfar as I can tell they are only set within
>> the constructor.
>> 
>> You could add 'final' to all declaration below:
>> 
>> XSLTC.java:
>> 
>> 53     private FeatureManager _featureManager;
>> 
>> TransformerFactoryImpl.java:
>> 
>> 232     private FeatureManager _featureManager;
>> 
>> XPathExpressionImpl.java:
>> 
>> 72     private FeatureManager featureManager;
>> 
>> XPathFactoryImpl.java:
>> 
>> 73         private FeatureManager _featureManager;
>> 
>> XPathImpl.java:
>> 
>>  74     FeatureManager featureManager;
>> 
>> Otherwise looks good.
>> 
>> -- daniel
>> 
>> On 10/22/13 6:55 PM, huizhe wang wrote:
>>> Hi,
>>> 
>>> This is a new implementation property that is consistent with recent
>>> additions as in JAXP 1.5 in that the scope and order are the same, refer
>>> to http://docs.oracle.com/javase/tutorial/jaxp/properties/scope.html. By
>>> default, feature enableExtensionFunctions is true. When
>>> FEATURE_SECURE_PROCESSING is set to true, the property is set to false
>>> allowing no extension functions. Setting FSP to false however will not
>>> change the value.
>>> 
>>> The property enableExtensionFunctions is supported by the following API:
>>> 
>>>      TransformerFactory factory = TransformerFactory.newInstance();
>>>      factory.setFeature(name, value);
>>> 
>>>      XPathFactory factory = XPathFactory.newInstance();
>>>      factory.setFeature(name, value);
>>> 
>>> 
>>> Webrevs:
>>> http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/
>>> 
>>> Thanks,
>>> Joe
>>> 
>> 
> 

-------------- next part --------------

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com