RFR: 8023862: deprecate HTTP proxying from RMI
Mandy Chung
mandy.chung at oracle.com
Wed Oct 23 22:13:04 UTC 2013
On 10/21/2013 5:23 PM, Stuart Marks wrote:
> Hi all,
>
> Please review the following spec change (deprecation) and change of a
> property default value.
>
> Briefly, RMI has some machinery that will attempt to tunnel RMI
> requests through HTTP under certain circumstances. This is a
> maintenance burden and also causes customer confusion. The change here
> deprecates the HTTP tunneling mechanism and changes a property to
> disable HTTP tunneling by default.
> ...
> Webrev:
>
> http://cr.openjdk.java.net/~smarks/reviews/8023862/webrev.0/
>
This change looks fine. Just minor comments:
java/rmi/server/RMISocketFactory.java
47 * value to {@code false} will re-enable the HTTP tunneling mechanisms.
nit: In the context of a specification, would it be appropriate to say
"enable" instead of "re-enable"?
sun/rmi/transport/proxy/RMIMasterSocketFactory.java
line 120-123 which is existing code: is this catch block redundant?
I assume that separate bug will be filed to update the RMI documentations.
Mandy
More information about the core-libs-dev
mailing list