JDK 8 RFR 4891331: BigInteger a.multiply(a) should use squaring code

Brian Burkhalter brian.burkhalter at oracle.com
Thu Oct 24 15:13:30 UTC 2013


On Oct 23, 2013, at 11:23 PM, Alan Eliasen wrote:

>   In short, these patches look good and effective, and will make many
> cases faster for many users without slowing down existing cases
> appreciably, and without users having to change their programs.  The
> code impact is minor and easily understandable, and any slowdown is a
> small constant-time (because of == check instead of .equals()).  It
> just does the right thing automatically.  Thanks, Brian!

You're welcome.

>   If I could approve this patch, I would.  Officially signing this
> message with my cryptographic key to indicate that it's me. :)

Thanks, Alan, your comments and review are much appreciated.

Brian


More information about the core-libs-dev mailing list