RFR: 8023168 - Cleanup LogManager class initialization and LogManager/LoggerContext relationship

Daniel Fuchs daniel.fuchs at oracle.com
Fri Sep 6 10:53:46 UTC 2013


Hi,

Here is a new webrev:

<http://cr.openjdk.java.net/~dfuchs/webrev_8023168/webrev.03/>

It incorporates Mandy comments in the following way:

   1. somewhen => somewhere
   2. setLogManager method comment updated
   3. checkPermission left unchanged (nothing done - as it is unclear
           that changing it wouldn't cause regressions).
   4. rootLogger comment moved above declaration
   5. initializationCalled not renamed - but new local variable named
      isRecursiveInitialization declared at time of use in
      ensureLogManagerInitialized(). Comments slightly refactored too.
   6. comment explaining the history of readPrimordialConfiguration()
      call removed.
   7. Logger.setParent left unchanged (nothing done - as it is unclear
           that changing it wouldn't cause regressions).


best regards,

-- daniel



More information about the core-libs-dev mailing list