RFR: Changes to disable and/or remove Solaris 32-bit from JDK8
Kumar Srinivasan
kumar.x.srinivasan at oracle.com
Mon Sep 9 03:09:57 UTC 2013
Hi David, Staffan, Alan,
I have addressed all the issues pointed and some more I found while jprt
testing.
The updated webrev for jdk is here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.1/
and the delta webrev since the last review webrev is here:
http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.1/webrev.delta/index.html
Thanks
Kumar
> Hi Kumar,
>
> A few minor comments ...
>
> src/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java
>
> Seems to me this is all dead now:
>
> 199 /*
> 200 * A wrinkle in the environment:
> 201 * 64-bit executables are stored under
> $JAVA_HOME/bin/os_arch
> 202 * 32-bit executables are stored under
> $JAVA_HOME/bin
> 203 */
> 204 String os_arch = System.getProperty("os.arch");
>
> os_arch is no longer used and the comment no longer applicable.
>
> ---
>
> src/solaris/bin/java_md_solinux.c
>
> This seems to force DUAL_MODE off regardless of what the user may set
> it to:
>
> #ifdef __solaris__
> ! # ifdef DUAL_MODE
> ! # undef DUAL_MODE
> ! # endif
>
> why doesn't it just not define DUAL_MODE?
>
> ---
>
> test/demo/jvmti/DemoRun.java
> test/sun/tools/jhat/HatRun.java
>
> It isn't clear to me why you need to retain the d64 variable at all.
>
> ---
>
> test/tools/launcher/ExecutionEnvironment.java
>
> typo: appopriate
>
>
> Thanks,
> David
> ----
>
>
>
> On 7/09/2013 2:47 AM, Kumar Srinivasan wrote:
>> Hello,
>>
>> Please review the changes to remove Solaris 32-bit binaries from JDK8
>> distros,
>> at this time the dual mode support in the launcher is being disabled.
>>
>> Message regarding this:
>> http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-September/003159.html
>>
>>
>> The jdk changes are here:
>> http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk.0/
>>
>> The top forest changes are here:
>> http://cr.openjdk.java.net/~ksrini/8020552/webrev.jdk8.0/
>>
>>
>> Thanks
>> Kumar
>>
>>
More information about the core-libs-dev
mailing list