RFR: 8024525 - Make Logger log methods call isLoggable()

Mandy Chung mandy.chung at oracle.com
Thu Sep 12 05:06:17 UTC 2013


On 9/11/2013 10:59 AM, Daniel Fuchs wrote:
> Hi,
>
> Please find below a changeset for a small logging RFE:
>
> 8024525 - Make Logger log methods call isLoggable()
>
> <http://cr.openjdk.java.net/~dfuchs/webrev_8024525/webrev.00/>
>

Looks good.

> ...
> The test is a bit obscure but it calls all the methods
> that have been modified and checks that they log when isLoggable()
> is true and don't log when isLoggable() is false.
>

I only skimmed on the test which looks okay.

thanks
Mandy




More information about the core-libs-dev mailing list