JDK 7u-dev review request 8024356: Double.parseDouble() is slow for long Strings

David Chase david.r.chase at oracle.com
Thu Sep 12 20:57:35 UTC 2013


Careful, I don't think I'm a Reviewer.
I merely had the misfortune to care a whole lot about this stuff once long long ago.

David

On 2013-09-12, at 4:49 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> On Sep 12, 2013, at 1:00 PM, David Chase wrote:
> 
>> On 2013-09-12, at 1:17 AM, Dmitry Nadezhin <dmitry.nadezhin at gmail.com> wrote:
>>> The optimal constant for double conversion could be 768 ,
>>> the optimal constant for float conversion could be 142,
>>> but I leave this optimization to JDK 9.
>> 
>> It would be helpful to mention in the proof/comment, that 768 refers to the
>> decimal representation that has had leading zeroes between decimal point
>> and mantissa trimmed.
> 
> I updated the webrev to include a comment for MAX_NDIGITS sans both hyperlink and the foregoing verbiage:
> 
> http://cr.openjdk.java.net/~bpb/8024356/
> 
> If there is any more tweaking of comments which needs to be effected prior to an approval request being posted to 7u-dev, please let me know.
> 
> Thanks,
> 
> Brian




More information about the core-libs-dev mailing list