RFR 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx]

David DeHaven david.dehaven at oracle.com
Fri Sep 13 17:54:19 UTC 2013


>>> Done, new webrev is here:
>> 
>> http://cr.openjdk.java.net/~bchristi/7199674/webrev.01/
>> 
>> 
>> On 9/6/13 4:09 PM, Mike Duigou wrote:
>>> 
>>> I am surprised that strdup isn't needed for the constant "?" string
>>> but java_props_md.c seems to include other constant strings in sprops
>>> so I will assume it is just never deallocated in the lifetime of the
>>> JVM.
>> 
>> My understanding is that C string literals go into static storage, and live for the life of the program.
> 
> My concern was mostly that nobody ever attempts to call free(sprops.user_home) which does't seem to happen.

Does it happen for the other strdup'ed fields? I didn't look at the code deeply enough to answer it myself... at first glance it doesn't introduce any leaks that weren't already there.

-DrD-




More information about the core-libs-dev mailing list