Please review two corrections for java.time

Joseph Darcy joe.darcy at oracle.com
Fri Sep 13 23:52:09 UTC 2013


Looks fine; cheers,

-Joe

On 9/13/2013 12:07 PM, roger riggs wrote:
> Ping, Reviewer needed for these minor updates, the test is now more 
> robust thanks to Peter's nudging.
>
> http://cr.openjdk.java.net/~rriggs/webrev-localtime-now-8023639/
>
> Please review for two corrections:
>
> -  The java/time/tck/java/time/TCKLocalTime test failed on a slow 
> runtime due to -Xcomp;
>     the test should be more lenient.   The test is not appropriate for 
> a conformance test
>     and is moved to java/time/test/java/time/TestLocalTime and is 
> updated to be
>     more robust in the face of DST changes.
>
> - The javadoc for the JapaneseEra.MEIJI era should indicate the start 
> date is 1868-01-01
>   to be consistent with java.util.Calendar.  Note that java.time does 
> not permit dates before Meiji 6
>   to be created since the calendar is not clearly defined until then.
>
> Thanks, Roger
>
>
>
>
>




More information about the core-libs-dev mailing list