RFR 8010293 <was> Re: Potential issue with CHM.toArray

[Paul Sandoz]

On Sep 10, 2013, at 4:34 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 09/09/2013 14:35, Paul Sandoz wrote:
>> On Sep 6, 2013, at 4:56 PM, Alan Bateman<Alan.Bateman at oracle.com>  wrote:
>> 
>>> :
>>> The comments are very educational as the resizing is difficult to completely grok without going through examples on a whiteboard. Anyway, I don't see anything obviously wrong after going through it. The test case is useful although creating the list of threads is quite a mouth full to take in.
>>> 
>> Yeah, i left that in a convoluted intermediate state and wanted to use CountedCompleter instead, see below for a revised and preferred version.
>> 
>> Paul.
> Thanks, the "preferred version" looks good to me. In passing I wonder if it should be renamed to ToArray.java while you're there.
> 

Thanks.

Renamed and pushed.

However, although the rename (made from a refactor in the IDE) was reflected in my local workspace (with no diffs) it did not appear to be reflected remotely:

  http://hg.openjdk.java.net/jdk8/tl/jdk/diff/ff6c76f7733e/test/java/util/concurrent/ConcurrentHashMap/toArray.java

:-( something very strange is going on.

I logged another bug and pushed a fix (with you as reviewer) to resolve this:

  http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5025ed287a4a

Apologies for the noise.

Paul.