Java 8 RFR 8024331: j.u.Map.computeIfPresent() default/nondefault implementations don't throw NPE if the remappingFunction is null and the key is absent

Mike Duigou mike.duigou at oracle.com
Tue Sep 17 21:33:44 UTC 2013


The Map/Defaults.java changes only test HashMap. It should probably be extended to test most/all of the other implementations.

I have some worry that the superfluous assignment of the Objects.requireNonNull() result might have a non-negligible cost. 

Mike

On Sep 17 2013, at 13:49 , Brian Burkhalter wrote:

> Please review this proposed patch at your convenience.
> 
> Summary:	Explicitly check for null remappingFunction parameter (and clean up similar code for consistency).
> Issue:		http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8024331
> Webrev:		http://cr.openjdk.java.net/~bpb/8024331/
> 
> Thanks,
> 
> Brian




More information about the core-libs-dev mailing list