RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

Naoto Sato naoto.sato at oracle.com
Thu Sep 19 23:14:30 UTC 2013


Thanks for checking. Looks good to me.

Naoto

On 9/19/13 3:12 PM, Alexander Zuev wrote:
> Hi Naoto,
>
>    I've checked that it works in C locale - since I'm setting LC_CTYPE to UTF-8 before calling both javac and java everything works as expected.
>
> With best regards,
> /Alex
>
> 20.09.2013, в 1:34, Naoto Sato <naoto.sato at oracle.com> написал(а):
>
>> Hi Alex,
>>
>> Should the test case also check the encoding of the platform? Does it work under the environment where the encoding is, say US-ASCII?
>>
>> Naoto
>>
>> On 9/19/13 9:43 AM, Alexander Zuev wrote:
>>> Hi,
>>>
>>>    please review my fix for 8025076: Fix for JDK-8017248 breaks jprt
>>> submission for non-unicode locales
>>>
>>>    The idea of the fix is to replace test case with the complex file
>>> name in it by the
>>> test that generates and compiles such file at the run time.
>>>
>>>    The webrev can be found at:
>>> http://cr.openjdk.java.net/~kizune/8025076/webrev.04/
>>>
>>> With best regards,
>>> /Alex
>>




More information about the core-libs-dev mailing list