SplittableRandom update

Martin Buchholz martinrb at google.com
Fri Sep 20 15:30:32 UTC 2013


Looks good.

Random nitpicks:

I prefer the old variable name DOUBLE_UNIT to DOUBLE_ULP; else you are
inventing a slightly different meaning for ULP.

I think using hex floating point literals is preferred:

-    private static final double DOUBLE_ULP = 1.0 / (1L << 53);
+    private static final double DOUBLE_ULP = 0x1.0p-53;

comment tidy:

-     * Appleby's MurmurHash3 algorithm See
-     * http://code.google.com/p/smhasher/wiki/MurmurHash3 . The mix32
+     * Appleby's MurmurHash3 algorithm (see
+     * http://code.google.com/p/smhasher/wiki/MurmurHash3). The mix32




On Fri, Sep 20, 2013 at 7:11 AM, Doug Lea <dl at cs.oswego.edu> wrote:

>
> In the course of writing up a report (coming soon) that includes
> discussion of SplittableRandom, we had a chance to further
> analyze and test things, resulting in a few small improvements. Plus
> some internal renamings to better reflect intent.
> Plus now with the same initial seed mechanics
> discussed a few days ago for ThreadLocalRandom.
>
> Thanks to Paul Sandoz for creating webrevs:
>
> https://bugs.openjdk.java.net/**browse/JDK-8025136<https://bugs.openjdk.java.net/browse/JDK-8025136>
>
> http://cr.openjdk.java.net/~**psandoz/tl/JDK-8025136-SR-**
> enhancements/webrev/<http://cr.openjdk.java.net/~psandoz/tl/JDK-8025136-SR-enhancements/webrev/>
>
> I think we need one more reviewer for it.
>
> -Doug
>



More information about the core-libs-dev mailing list