Fwd: Re: type anno test code check in

[Charlie Wang]

OK, here's the link 
http://cr.openjdk.java.net/~pzhang/Charlie/TypeAnnotation1/webrev/
Also I would appreciate it if you could check in the code once you are 
OK with it, because these tests have gone through numerous rounds of 
review and I would like to wrap it up asap.
If others have comments, I will file RFE bugs to track them.




- Charlie


On 2013/9/23 16:01, Joel Borggren-Franck wrote:
> Hi Charlie,
>
> Please upload a webrev that I and others can review.
>
> cheers
> /Joel
>
> On 2013-09-23, Charlie Wang wrote:
>> Hi Joel,
>>    Fixed the issues people raised recently. Could you commit the code
>> for me? Files are attached. Thanks.
>>
>>
>> - Charlie
>>
>> On 2013/9/11 22:44, Joel Borggren-Franck wrote:
>>> Hi Charlie,
>>>
>>> These tests should go into TL, I can commit them there. The test review
>>> cycle should be on core-libs-dev at openjdk.java.net.
>>>
>>> However the test are not ready yet.
>>>
>>> If you run the tests vs jdk8-b106 or a recent copy of TL there is a few
>>> failures. How can I as a developer see the exact source which caused the
>>> failure?
>>>
>>> Further, there is an @author tag between two jtreg tags, @build and
>>> @run in almost every file. Please don't do that.
>>>
>>> As a user of these tests there needs to be a way for me to:
>>>
>>> 1) Understand the tests / ensure that the tests are correct
>>> 2) Run the tests
>>> 3) Understand what causes tests failures
>>>
>>> Out of these only 2) is currently easy. 1) is hard and 3) looks
>>> impossible.
>>>
>>> Here is what you need to do to bring this forward:
>>>
>>> - At a minimum you need to document how the tests work. It is not clear
>>>    at the moment.
>>>
>>> - Please explain why are the helpers split out into 2 interfaces and 4
>>>    classes?
>>>
>>> - You also need to improve failure friendliness. If a tests fail, it
>>>    must be possible to see the java source of the generated program that
>>>    fails together with a decent explanation of what went wrong.
>>>
>>> If this is currently available, please indicate how to do it.
>>>
>>> cheers
>>> /Joel
>>>
>>> On 2013-09-11, Charlie Wang wrote:
>>>> Hi,
>>>>    I'm looking for a committer to help me check in type annotation
>>>> reflection test code. Could someone give me a hand?
>>>>
>>>>
>>>>
>>>> Thanks,
>>>> Charlie
>>>>
>>>> -------- Original Message --------
>>>> Subject: 	Re: type anno test code check in
>>>> Date: 	Tue, 10 Sep 2013 10:29:02 -0700
>>>> From: 	Alex Buckley <alex.buckley at oracle.com>
>>>> Organization: 	Oracle Corporation
>>>> To: 	Charlie Wang <charlie.wang at oracle.com>
>>>>
>>>>
>>>>
>>>> Ask on type-annotations-dev for a Committer in the Type Annotations
>>>> Project to push the tests for you. The tests will go in the jdk repo.
>>>>
>>>> Alex
>>>>
>