RFR 8025173 : HashMap.put() replacing an existing key can trigger a resize()

Martin Buchholz martinrb at google.com
Wed Sep 25 23:03:19 UTC 2013


Looks good.
I would only suggest the stylistic improvement of using proper /** javadoc
comments even for private test methods instead of /*


On Wed, Sep 25, 2013 at 3:19 PM, Brent Christian <brent.christian at oracle.com
> wrote:

> Please review this change for 8025173, "HashMap.put() replacing an
> existing key can trigger a resize()."
>
> A description of the problem can be found in the bug report:
> http://bugs.sun.com/view_bug.**do?bug_id=8025173<http://bugs.sun.com/view_bug.do?bug_id=8025173>
>
> Thanks to Doug Lea for sending in the diff for HashMap.java.
>
> Webrev is here:
> http://cr.openjdk.java.net/~**bchristi/8025173/webrev.00/<http://cr.openjdk.java.net/~bchristi/8025173/webrev.00/>
>
> Results of an automated test run look okay.
>
> Thanks,
> -Brent
>



More information about the core-libs-dev mailing list