RFR: 8009411 : getMethods should not inherit static methods from interfaces
Joel Borggrén-Franck
joel.franck at oracle.com
Thu Sep 26 14:53:26 UTC 2013
Hi again,
New webrev with more tests contributed by Amy Lu.
http://cr.openjdk.java.net/~jfranck/8009411/webrev.02/
No change to non-test code since webrev.01
cheers
/Joel
On 2013-09-12, Joel Borggrén-Franck wrote:
> Hi again,
>
> New webrev: http://cr.openjdk.java.net/~jfranck/8009411/webrev.01/
>
> Thanks to Remi and Peter for the quick feedback, I've updated the code
> to use for-each as well as fixing getMethod(...).
>
> Andreas Lundblad also added ~100 testcases for getMethod(), both
> positive and negative.
>
> Please review
>
> cheers
> /Joel
>
> On 2013-09-09, Joel Borggrén-Franck wrote:
> > Hi
> >
> > Pleaser review fix for 8009411 : getMethods should not inherit static methods from interfaces
> >
> > The issue is that since we added static methods to interfaces those have erroneously been reflected in getMethods of implementing classes. This fix filters out static interface methods from superinterfaces when adding methods. I have also added a note to the javadoc for both getMembers and getDeclaredMembers pointing this out (though it is implied from JLS). Webrev is based on the clarification to getMethods and friends out for review on this list.
> >
> > Webrev: http://cr.openjdk.java.net/~jfranck/8009411/webrev.00/
> > Bug is here: http://bugs.sun.com/view_bug.do?bug_id=8009411
> >
> > For oracle reviewers, ccc is approved.
> >
> > cheers
> > /Joel
More information about the core-libs-dev
mailing list