RFR 8025173 : HashMap.put() replacing an existing key can trigger a resize()

Martin Buchholz martinrb at google.com
Fri Sep 27 00:16:50 UTC 2013


Yes, I see your problem.  It's one we have in jsr166 development as well.

We would like to use javadoc style, and have the javadoc tool warn us of
"real bugs" in our javadoc (even private methods) BUT we don't want javadoc
to enforce the same high standards for public methods, e.g. don't require
all of the @param for type parameters.

I think javadoc's current increased level of warning will have the
unintended consequence of causing users to revert to /* comments.
I would disable the more controversial ones by default.


On Thu, Sep 26, 2013 at 10:51 AM, Brent Christian <
brent.christian at oracle.com> wrote:

> On 9/25/13 4:03 PM, Martin Buchholz wrote:
>
>> Looks good.
>> I would only suggest the stylistic improvement of using proper /**
>> javadoc comments even for private test methods instead of /*
>>
>
> The comments were meant as internal documentation and not "real" javadoc.
>  After dabbling with some doclint cleanup a while ago, I'm inclined now to
> only use /** if what I'm writing will be doclint-clean.  testItr(), for
> instance, would (at least) need @param tags and that's more than I thought
> was needed for this test code.
>
> So that was the thinking there.
>
> Thanks,
> -Brent
>



More information about the core-libs-dev mailing list