RFR: 8025067: (xs) Arrays.parallelPrefix may fail to throw NPE for null op

[Henry Jen]

The test itself looks good.

Like you said, the cut-n-paste code need some cleanup, you didn't need those no-message version and the array version of assertThrows.

Cheers,
Henry


On Sep 30, 2013, at 3:39 PM, Mike Duigou <mike.duigou at oracle.com> wrote:

> After posting the webrev I decided that an update to the regression test was going to be necessary. Here's the updated webrev including additional unit tests. Unfortunately I had to cut-and-paste some "library" code for exception checking. The "library" code will need to be cleaned up eventually.
> 
> http://cr.openjdk.java.net/~mduigou/JDK-8025067/1/webrev/
> 
> Mike
> 
> On Sep 30 2013, at 15:00 , Henry Jen wrote:
> 
>> Looks good to me.
>> 
>> Cheers,
>> Henry
>> 
>> On Sep 30, 2013, at 2:27 PM, Mike Duigou <mike.duigou at oracle.com> wrote:
>> 
>>> Hello all;
>>> 
>>> This changeset fixes a small corner case where Arrays.parallelPrefix (all variants) failed to throw NPE if the operation was null. If the array or range was empty then op was never examined. The solution in this patch is to add an an explicit Objects.requireNonNull(op) check.
>>> 
>>> http://cr.openjdk.java.net/~mduigou/JDK-8025067/0/webrev/
>>> 
>>> Cheers,
>>> 
>>> Mike
>> 
>