jmx-dev <Core Libs Dev>[9] Review Request for 8038795: tidy warnings cleanup for javax.management

Daniel Fuchs daniel.fuchs at oracle.com
Tue Apr 1 14:53:47 UTC 2014


On 4/1/14 4:41 PM, alexander stepanov wrote:
> Hello,
>
> Please see the updated webrev here:
> http://cr.openjdk.java.net/~yan/8038795/webrev.01/

Thanks Alexander,

It looks good!

-- daniel

>
>  > I just assume the removal of the </p> isn't really necessary.
> Yes, probably. That was done just to make tidy happy.
>
> Thanks,
> Alexander
>
> On 01.04.2014 17:44, Daniel Fuchs wrote:
>> Hi Alexander,
>>
>> Looks good.
>>
>> I think I would remove the leading <p> in
>> http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/remote/JMXPrincipal.java.frames.html
>>
>> as well. If you don't please check that the generated javadoc for
>> JMXPrincipal.java still looks good.
>>
>> While you're at it maybe you should remove the strange <br> 
>> between the @param tags in
>> <http://cr.openjdk.java.net/~yan/8038795/webrev.00/src/share/classes/javax/management/openmbean/CompositeType.java.frames.html>
>>
>>
>> such as:
>>
>>   86      * <br> 
>>
>> best regards,
>>
>> -- daniel
>>
>>
>> On 4/1/14 2:57 PM, Alan Bateman wrote:
>>>
>>> I think you are looking for jmx-dev so forwarding to that list.
>>>
>>> On 01/04/2014 13:51, alexander stepanov wrote:
>>>> Hello,
>>>>
>>>> Could you please review the fix for the following bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8038795
>>>>
>>>> Webrev corresponding:
>>>> http://cr.openjdk.java.net/~yan/8038795/webrev.00/
>>>>
>>>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code
>>>> affected.
>>>>
>>>> Thanks.
>>>>
>>>> Regards,
>>>> Alexander
>>>
>>
>




More information about the core-libs-dev mailing list