<Core Libs Dev>[9] Review Request for 8039488: tidy warnings cleanup for javax.sql

Lance Andersen lance.andersen at oracle.com
Wed Apr 9 14:04:48 UTC 2014


Hi Alexander,

looks fine.

Best
Lance
On Apr 9, 2014, at 7:58 AM, alexander stepanov <alexander.v.stepanov at oracle.com> wrote:

> Hello Lance,
> 
> Thanks; please see the updated webrev: http://cr.openjdk.java.net/~yan/8039488/webrev.01/
> 
> Regards,
> Alexander
> 
> On 09.04.2014 14:10, Lance @ Oracle wrote:
>> I think this looks ok but a couple of suggestions
>> 
>> *src/share/classes/javax/sql/rowset/spi/package.html - *The URL links at the bottom of the page need updated, please address them as part of this putback if possible
>> *
>> *
>> *src/share/classes/javax/sql/package.html *- I would use ™  as part of the change on lines 40 and 42
>> 
>> Best
>> Lance
>> 
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 <tel:+1.781.442.2037>
>> Oracle Java Engineering
>> 1 Network Drive <x-apple-data-detectors://34/0>
>> Burlington, MA 01803 <x-apple-data-detectors://34/0>
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> Sent from my iPad
>> 
>> On Apr 9, 2014, at 5:45 AM, alexander stepanov <alexander.v.stepanov at oracle.com <mailto:alexander.v.stepanov at oracle.com>> wrote:
>> 
>>> Hello,
>>> 
>>> Could you please review the fix for the following bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8039488
>>> 
>>> Webrev corresponding:
>>> http://cr.openjdk.java.net/~yan/8039488/webrev.00/ <http://cr.openjdk.java.net/%7Eyan/8039488/webrev.00/>
>>> 
>>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code affected.
>>> 
>>> Thanks.
>>> 
>>> Regards,
>>> Alexander
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com






More information about the core-libs-dev mailing list