JDK 9 RFR of 8039474: sun.misc.CharacterDecoder.decodeBuffer should use getBytes(iso8859-1)

Chris Hegarty chris.hegarty at oracle.com
Thu Apr 10 09:04:26 UTC 2014


On 10 Apr 2014, at 02:19, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> Hello,
> 
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8039474
> Patch:	http://cr.openjdk.java.net/~bpb/8039474/webrev.00/

The change looks fine to me Brian.

Trivially, you could ( but of not have to ) use java.nio.charset.StandardCharsets.ISO_8859_1 to avoid the cost of String to CharSet lookup.

-Chris,

> 
> The change is to specify the charset for the String where none had been before. The extant test sun/misc/Encode/GetBytes.java appears to suffice for this.
> 
> Thanks,
> 
> Brian




More information about the core-libs-dev mailing list