8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour

Martin Buchholz martinrb at google.com
Wed Apr 16 17:47:49 UTC 2014


Here you access elementCount outside the synchronized block, which is
a data race

+    public boolean addAll(int index, Collection<? extends E> c) {
         if (index < 0 || index > elementCount)
             throw new ArrayIndexOutOfBoundsException(index);




On Wed, Apr 16, 2014 at 10:30 AM, Mike Duigou <mike.duigou at oracle.com>wrote:

> Yes. This has been corrected.
>
> Mike
>
> On Apr 16 2014, at 08:19 , Martin Desruisseaux <
> martin.desruisseaux at geomatys.fr> wrote:
>
> > Hello all
> >
> > Le 15/04/14 18:14, Mike Duigou a écrit :
> >> I have updated the webrev with what I hope is the final form:
> >>
> >> http://cr.openjdk.java.net/~mduigou/JDK-8020860/1/webrev/
> >
> > The first changes in the javadoc contains "{@code #keys keys}" and
> > "{@code #elements elements}". I presume that you mean {@link} instead of
> > {@code}?
> >
> >    Martin
> >
>
>



More information about the core-libs-dev mailing list