RFR [8054221] StringJoiner imlementation optimization

Martin Buchholz martinrb at google.com
Tue Aug 5 01:29:56 UTC 2014


On Mon, Aug 4, 2014 at 10:04 AM, Claes Redestad <claes.redestad at oracle.com>
wrote:

> Hi,
>
>  - is there a sufficiently good reason not to use an ArrayList<String>
> over a manually resized String[] here? It'd simplify and use
> overflow-conscious code at a negligible performance cost
>

This is a core library - it should be fanatically devoted to high
performance.  Should HashMap have an internal ArrayList instead of an array?


>  - nit: elt(s) -> element(s)
>  - nit: always use curly braces


Nah.



More information about the core-libs-dev mailing list