RFR 8042003: java/lang/Math tests have external dependency on sun.misc.DoubleConsts and sun.misc.FloatConsts

Amy Lu amy.lu at oracle.com
Tue Aug 19 13:50:27 UTC 2014


On 8/19/14, 3:09 AM, Mandy Chung wrote:
> On 8/18/14 12:49 AM, Amy Lu wrote:
>> There are jdk tests that have dependency on sun.misc.DoubleConsts and 
>> sun.misc.FloatConsts.
>> This fix is to remove above internal API dependency from the tests.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8042003
>> webrev: http://cr.openjdk.java.net/~ewang/amylu/JDK-8042003/webrev.00/
>>
> In addition to Joe's comment, DoubleUtils and FloatUtils are
> needed by test/java/lang/Math/Tests.java and a few other math
> tests.  It may be better to include them in test/java/lang/Math
> rather than in the testlibrary.
>
>
> Mandy
>

Thank you Mandy and Joe for your comments!

To confirm, DoubleUtils and FloatUtils contain *only* constants that are 
not defined in java.lang.{Float, Double}, and tests fixed by using 
constants from 1) java.lang.{Float, Double} if constants defined there; 
2) DoubleUtils and FloatUtils only for additional constants that are not 
in java.lang.{Float, Double}.

DoubleUtils and FloatUtils now moved to test/java/lang/Math, the updated 
patch:

http://cr.openjdk.java.net/~ewang/amylu/JDK-8042003/webrev.01/

Thanks,
Amy






More information about the core-libs-dev mailing list