RFR 8055262: Update jdk/test/java/util/Base64 tests to use java.util.Base64 instead of sun.misc.BASE64Encoder/Decoder

Mandy Chung mandy.chung at oracle.com
Tue Aug 19 19:27:59 UTC 2014


Pushed.  Thanks for the contribution.

Mandy

On 8/19/14 6:40 AM, Amy Lu wrote:
> Thank you Mandy and Sherman for your review.
>
> I'll need your help to push this.
>
> Thanks,
> Amy
>
> On 8/19/14, 1:31 AM, Mandy Chung wrote:
>> On 8/18/14 12:08 AM, Amy Lu wrote:
>>> There are two tests under jdk/test/java/util/Base64 that have 
>>> dependency on internal API sun.misc.BASE64Encoder 
>>> sun.misc.BASE64Decoder
>>> java/util/Base64/TestBase64Golden.java
>>> java/util/Base64/TestBase64.java
>>>
>>> This fix is to remove the internal API dependency from the tests.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8055262
>>> webrev: http://cr.openjdk.java.net/~ewang/amylu/JDK-8055262/webrev.00/
>>>
>>
>> This patch looks okay.  I think it's fine to remove the test case 
>> comparing with sun.misc.BASE64 implementation from these tests.
>>
>> Mandy
>




More information about the core-libs-dev mailing list