RFR(S): 8055055: Improve numeric parsing in java.sql

[Lance Andersen]

I think this is OK.  However, I want to write some additional tests to reduce the chance of regression and add this as part of the putback

I am going to be out of the office for a few days so doubt I will get to this for another week or so

Best,
Lance
On Aug 13, 2014, at 3:42 PM, Claes Redestad <claes.redestad at oracle.com> wrote:

> Thanks, Lance!
> 
> I only ran the jtreg tests under jdk/test/java/sql locally for this (29 passed).
> 
> /Claes
> 
> On 2014-08-13 20:14, Lance Andersen wrote:
>> I will take a look this week.  Did you run the unit tests to make sure they still pass?
>> 
>> 
>> On Aug 13, 2014, at 12:49 PM, Claes Redestad <claes.redestad at oracle.com <mailto:claes.redestad at oracle.com>> wrote:
>> 
>>> Hi,
>>> 
>>> can I have a review of this small patch which improves performance of java.sql.Time::valueOf (~1.3x) and java.sql.Timestamp::valueOf (~1.9x).
>>> 
>>> Uses Integer.parseInt with offset to make intermediary substrings unnecessary and improves the nanosecond fraction calculation to not use String concatenation.
>>> 
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8055055
>>> webrev: http://cr.openjdk.java.net/~redestad/8055055/webrev.0/ <http://cr.openjdk.java.net/%7Eredestad/8055055/webrev.0/>
>>> 
>>> Thanks!
>>> 
>>> /Claes
>> 
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
>> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>> 
>> 
>> 
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com