RFR 8042003: java/lang/Math tests have external dependency on sun.misc.DoubleConsts and sun.misc.FloatConsts

[Joe Darcy]

Hello,

Catching up on email; the .02 version looks good.

Thanks,

-Joe

On 08/21/2014 07:38 AM, Amy Lu wrote:
> On 8/21/14, 9:56 AM, Mandy Chung wrote:
>>
>> On 8/20/2014 6:39 PM, Amy Lu wrote:
>>> On 8/21/14, 8:54 AM, Mandy Chung wrote:
>>>>
>>>> On 8/20/2014 6:26 AM, Amy Lu wrote:
>>>>> Patch updated: 
>>>>> http://cr.openjdk.java.net/~ewang/amylu/JDK-8042003/webrev.02/ 
>>>>
>>>> test/java/lang/Double/ParseHexFloatingPoint.java
>>> No dependency on the new DoubleConsts.
>>> Previous dependency on sun.misc.DoubleConsts have been replaced with 
>>> java.lang.Double
>>>
>>>> test/java/lang/Double/ToHexString.java
>>> This one has dependency on the new DoubleConsts.
>>>
>>> 28: * @library ../Math
>>> 29: * @build DoubleConsts
>>> 85:                    DoubleConsts.EXP_BIAS;
>>>
>>
>> Ah. I missed that.
>>
>> Looks good.
>> Mandy
> Thank you for reviewing!
>
> May I get your help for push the change?
>
> Thanks,
> Amy
>>
>>> Thanks,
>>> Amy
>>>> - they don't depend on DoubleConsts, do they?
>>>>
>>>> Otherwise, looks good.
>>>>
>>>> Mandy
>>>>
>>>>
>>>
>>
>