RFR: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM
Martin Buchholz
martinrb at google.com
Tue Aug 26 20:38:35 UTC 2014
I'll submit soonish.
@summary second line indented.
I added some gratuitous assertions to the test:
// check data integrity while we're here
byte[] bytes = baos.toByteArray();
if (bytes.length != n)
throw new AssertionError("wrong length");
if (bytes[0] != 'x' ||
bytes[bytes.length - 1] != 'x')
throw new AssertionError("wrong contents");
On Tue, Aug 26, 2014 at 12:07 AM, Alan Bateman <Alan.Bateman at oracle.com>
wrote:
>
> In the mean-time then my only concern is that pushing a test with @ignore
> is just adding to the technical debt. Such tests are unlikely to be run or
> maintained. If you do push it with @test then a minor comment is to maybe
> push in the second line of @summary so that it is more distinguishable from
> the @ lines.
I don't think it particularly adds to the technical debt because there's an
existing pile of @ignored tests that share the same reason, that will all
be handled together ... in the fullness of time.
More information about the core-libs-dev
mailing list