[7u-dev] Request for Approval and Review: 8017212: File.createTempFile requires unnecessary "read" permission
Ivan Gerasimov
ivan.gerasimov at oracle.com
Thu Aug 28 11:09:21 UTC 2014
Hello!
Could someone please review this mostly strait-forward backport?
The only conflict in the fix was a curly bracket.
The regtest had a few conflicts, so it seemed better to replace it with
the latest version from jdk8u.
Thanks in advance,
Ivan
On 15.08.2014 19:41, Ivan Gerasimov wrote:
> Hello!
>
> I'd like to ask an approval to backport 8017212 into 7u-dev.
>
> The patch does not apply cleanly, however the required modifications
> are quite small.
> Nevertheless, I will need a peer review for this.
>
> The webrev for jdk7:
> http://cr.openjdk.java.net/~igerasim/8017212/0/webrev/
>
> The difference, compared to jdk8 is:
> src/share/classes/java/io/File.java -- curly bracket at the end of
> the line
> test/java/io/File/createTempFile/SpecialTempFile.java -- there were
> conflicts due to backport of 8025128, so the test was just copied
> verbatim from the latest jdk8u.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8017212
> Jdk8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/10d2a4b1e576
> Jdk8 review:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018354.html
>
> The change was tested with jprt on all supported platforms.
> All the io tests, including added and updated, passed.
>
> Sincerely yours,
> Ivan
>
>
More information about the core-libs-dev
mailing list