RFR: Update java/nio/charset/Charset/NIOCharsetAvailabilityTest.java to eliminate dependency on sun.misc.Launcher
Amy Lu
amy.lu at oracle.com
Mon Dec 1 07:55:15 UTC 2014
On 11/28/14 9:25 PM, Alan Bateman wrote:
> On 28/11/2014 10:35, Amy Lu wrote:
>> jdk/test/java/nio/charset/Charset/NIOCharsetAvailabilityTest.java has
>> dependency on sun.misc.Launcher
>> This fix is to remove above internal API dependency from the test.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8066131
>> webrev: http://cr.openjdk.java.net/~weijun/8066131/webrev.00/
> The change looks okay but I think the test needs a bigger overhaul.
> The main thing is that the extensions directory goes away via JEP 220
> so I think some of this test can go away too. The other thing is that
> getClassList appears to treat URL paths as file paths so it might not
> never have worked as expected on all platforms.
>
> -Alan.
Yes, the extensions part should be removed.
Please review the updated version:
http://cr.openjdk.java.net/~weijun/8066131/webrev.01
Thanks,
Amy
More information about the core-libs-dev
mailing list