RFR 8060068 : Remove the static initializer block from DriverManager

Ulf Zibis Ulf.Zibis at CoSoCo.de
Mon Dec 1 20:27:36 UTC 2014


Hi Lance,

to me it's irritating, why there are 2 methods:
- initDriversIfNeeded()
- loadInitialDrivers()
I would combine both to one method.
In lines 90 + 92 there are double spaces.

-Ulf


Am 01.12.2014 um 17:52 schrieb Lance Andersen:
> Hi all,
>
> Looking for a review for this change to DriverManager to reduce the possibility on a deadlock on <clinit>. that I have been discussing with Mandy.
>
>
> The change removes the static initializer block as well as the synchronized keyword from registerDriver.
>
> The webrev can be found at http://cr.openjdk.java.net/%7Elancea/8060068/webrev.02/
>
>
> Best,
> Lance
>
>
> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com
>
>
>
>




More information about the core-libs-dev mailing list