RFR 8060068 : Remove the static initializer block from DriverManager

Lance Andersen lance.andersen at oracle.com
Wed Dec 3 17:10:25 UTC 2014


On Dec 3, 2014, at 11:57 AM, Mandy Chung <mandy.chung at oracle.com> wrote:

> 
> On 12/3/2014 8:18 AM, Lance Andersen wrote:
>> 
>> Thank you Sean.  As this code path is only called 1 time, i am not concerned  that performance will be an issue.  If you and Mandy prefer me to remove it, I can, just let me know.
>> 
>> Yes, I agree it is narrow.  The suggestion to add the limited doPriviliged came up in a review of RowSetProvider which is why I figured I would add it here also.  Now that was quite some time ago, so I understand our position might have changed.
> 
> Since Sean will look into the guide when it's best to use limited doPrivileged, you can add the appropriate ones later in JDK 9 and taking it out also makes it easier to backport if any customer requests it.   I'm okay with webrev.04 and no need to generate a new webrev with the doPrivileged change reverted.

Change reverted and for completeness, the  webrev is at http://cr.openjdk.java.net/~lancea/8060068/webrev.05/


Best,
Lance
> Thanks
> Mandy
> 
> 



Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com






More information about the core-libs-dev mailing list