RFR: 8065172: More core reflection final and volatile annotations

Paul Sandoz paul.sandoz at oracle.com
Tue Dec 9 11:23:25 UTC 2014


On Dec 8, 2014, at 11:47 PM, Martin Buchholz <martinrb at google.com> wrote:
> Webrev updated.

Not quite sure how the webrev was updated:

  http://cr.openjdk.java.net/~martin/webrevs/openjdk9/core-reflection-more-safety/

But the patch file 

  http://cr.openjdk.java.net/~martin/webrevs/openjdk9/core-reflection-more-safety/core-reflection-more-safety.patch

seems out of sync with the contents for each diff e.g:

http://cr.openjdk.java.net/~martin/webrevs/openjdk9/core-reflection-more-safety/src/java.base/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java.sdiff.html

Do you observe the same?


>  Field updaters are gone.  I intend to commit soon.
> 

I went through the diffs individually and it seems fine but i don't have 100% confidence that the webrev has not been unintentionally mangled.

Paul.



More information about the core-libs-dev mailing list