RFR 9: 8056238: (process) ProcessBuilder.redirectError spec has a broken link

Martin Buchholz martinrb at google.com
Fri Dec 12 21:26:54 UTC 2014


Oh I think I know.  #redirectErrorStream is ambiguous, because the
method name is overloaded.  In the distant past, it would choose one
of the methods to target, probably the first, but now you need to be
explicit?

It might be very slightly better to refer to the setter

* <p>If the {@link #redirectErrorStream(boolean) redirectErrorStream}

On Fri, Dec 12, 2014 at 1:16 PM, roger riggs <roger.riggs at oracle.com> wrote:
> Hi,
>
> Not sure, but it used to be ok to refer to a method without the ().
> Now the name on the html target has a '--' suffix so a bare link reference
> does not work.
>
> Roger
>
>
> On 12/12/2014 4:07 PM, Martin Buchholz wrote:
>>
>> +1
>> (how did this not get fixed in previous cleanups!?)
>>
>> On Fri, Dec 12, 2014 at 11:53 AM, roger riggs <roger.riggs at oracle.com>
>> wrote:
>>>
>>> Please review this fix for bad link in javadoc:
>>>
>>> jdk/src/java.base/share/classes/java/lang/ProcessBuilder.java
>>> @@ -748,11 +748,11 @@
>>>        * Process#getErrorStream()}.
>>>        * If the destination is set to any other value, then
>>>        * {@link Process#getErrorStream()} will return a
>>>        * <a href="#redirect-output">null input stream</a>.
>>>        *
>>> -     * <p>If the {@link #redirectErrorStream redirectErrorStream}
>>> +     * <p>If the {@link #redirectErrorStream() redirectErrorStream}
>>>        * attribute has been set {@code true}, then the redirection set
>>>        * by this method has no effect.
>>>        *
>>>        * @param  destination the new standard error destination
>>>        * @return this process builder
>>>
>>> Issue:
>>>      8056238: (process) ProcessBuilder.redirectError spec has a broken
>>> link
>>>
>>> The built javadoc has the link working.
>>>
>>> Thanks, Roger
>>>
>



More information about the core-libs-dev mailing list