RFR: 8067377: My hobby: caning, then then canning, the the can-can

Lance @ Oracle lance.andersen at oracle.com
Sat Dec 13 12:34:19 UTC 2014


Good eyes Daniel!


Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
Sent from my iPad

> On Dec 13, 2014, at 7:27 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
>> On 12/12/14 10:34 PM, Martin Buchholz wrote:
>> Hi Joe, Lance, Roger,
>> 
>> Fix ALL the stutters!
>> 
>> https://bugs.openjdk.java.net/browse/JDK-8067377
>> http://cr.openjdk.java.net/~martin/webrevs/openjdk9/double-trouble/
> 
> Hi Martin,
> 
> Impressive!  There may still be a typo in the one below:
> 
> diff --git a/src/java.naming/share/classes/com/sun/jndi/ldap/LdapReferralException.java b/src/java.naming/share/classes/com/sun/jndi/ldap/LdapReferralException.java
> --- a/src/java.naming/share/classes/com/sun/jndi/ldap/LdapReferralException.java
> +++ b/src/java.naming/share/classes/com/sun/jndi/ldap/LdapReferralException.java
> @@ -59,7 +59,7 @@
>   * objects.
>   * <p>
>   * If an exception was recorded while processing a chain of
> -  * <tt>LdapReferralException</tt> objects then is is throw once
> +  * <tt>LdapReferralException</tt> objects then it is throw once
>   * processing has completed.
> 
> 
> Shouldn't this be:
> 
> -  * <tt>LdapReferralException</tt> objects then is is throw once
> +  * <tt>LdapReferralException</tt> objects then it is thrown once
> 
> (throw -> thrown)
> 
> best regards,
> 
> -- daniel
> 



More information about the core-libs-dev mailing list