RFR(s): 8035117: TEST_BUG: java/rmi/server/RemoteObject/notExtending/NotExtending.java can fail with timeout

Stuart Marks stuart.marks at oracle.com
Tue Dec 16 21:42:11 UTC 2014


Thanks Lance, I appreciate it. That's what I get for posting a code review on a 
Friday afternoon during the holiday season. :-)

s'marks

On 12/16/14 9:42 AM, Lance Andersen wrote:
> Looks OK stuart.  Another test I looked at last week but forgot to reply
>
> On Dec 16, 2014, at 12:40 PM, Stuart Marks <stuart.marks at oracle.com 
> <mailto:stuart.marks at oracle.com>> wrote:
>
>> Hi, any reviewers for this changeset?
>>
>> Thanks,
>>
>> s'marks
>>
>> On 12/12/14 12:05 PM, Stuart Marks wrote:
>>> Hi all,
>>>
>>> Please review this small fix and cleanup to this test. The old version would
>>> force garbage collection of an unreferenced RMI object by allocating lots and
>>> lots of memory until OOME is received, which takes a long time and could cause a
>>> timeout. The better approach is simply to unexport the object.
>>>
>>> I also did additional cleanups, such as not leaking the reference to 'this' from
>>> within the constructor, making comments and messages more concise, etc.
>>>
>>> Webrev:
>>>
>>> http://cr.openjdk.java.net/~smarks/reviews/8035117/webrev.0/ 
>>> <http://cr.openjdk.java.net/%7Esmarks/reviews/8035117/webrev.0/>
>>>
>>> Bug:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8035117
>>>
>>> Thanks,
>>>
>>> s'marks
>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>
>
>




More information about the core-libs-dev mailing list