RFR JDK-8067870: Fix java.io.ObjectInputStream.PeekInputStream#skip

Pavel Rappo pavel.rappo at oracle.com
Thu Dec 18 15:06:18 UTC 2014


Updated webrev: http://cr.openjdk.java.net/~prappo/8067870/webrev.01/
Will push as soon as I see test results.

P.S. The thing was lurking there since 28-NOV-2000, ver. 1.106

-Pavel

> On 18 Dec 2014, at 14:25, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 18/12/2014 13:32, Pavel Rappo wrote:
>> Hi everyone,
>> 
>> Could you please review my change for JDK-8067870?
>> 
>> http://cr.openjdk.java.net/~prappo/8067870/webrev.00/
>> 
>> -------------------------------------------------------------------------------
>> I suppose it's the first time this method gets executed. Ever :)
> Probably just not interesting to do on a serialized stream.
> 
> Your change looks good (and well spotted). I agree with Roger about converting what you have into a test to push with the fix.
> 
> -Alan




More information about the core-libs-dev mailing list