8034175: Remove use of UseVMInterruptibleIO from tests

Chris Hegarty chris.hegarty at oracle.com
Tue Feb 11 10:36:27 UTC 2014


Looks good to me Alan.

-Chris.

On 11 Feb 2014, at 10:31, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> 
> Interruptible I/O was a (mostly Solaris only) mis-feature that we've been eradicating over a number of releases. In JDK 6 the VM option UseVMInterruptibleIO was added to allow it be disabled, in JDK 7 it was switched to being disabled by default, in JDK 8 we removed the dependency from the libraries (except classic networking, meaning java.net, that still needs to be done). Now in JDK 9, Frederic Parain is removing the VM support as part of JDK-6546236 [1].
> 
> As part of that discussion, Frederic pointed out that we still have 3 tests in the jdk repository that use specify this option. The attached (trivial) patch removes the option from the 3 tests. In each case then I've removed the @run line as there isn't any obvious that requires a new VM be spun up for each test.
> 
> -Alan
> 
> [1] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-February/010839.html
> 
> 
> diff --git a/test/java/nio/file/Files/InterruptCopy.java b/test/java/nio/file/Files/InterruptCopy.java
> --- a/test/java/nio/file/Files/InterruptCopy.java
> +++ b/test/java/nio/file/Files/InterruptCopy.java
> @@ -25,7 +25,6 @@
>  * @bug 4313887 6993267
>  * @summary Unit test for Sun-specific ExtendedCopyOption.INTERRUPTIBLE option
>  * @library ..
> - * @run main/othervm -XX:-UseVMInterruptibleIO InterruptCopy
>  */
> 
> import java.nio.file.*;
> diff --git a/test/java/util/concurrent/BlockingQueue/Interrupt.java b/test/java/util/concurrent/BlockingQueue/Interrupt.java
> --- a/test/java/util/concurrent/BlockingQueue/Interrupt.java
> +++ b/test/java/util/concurrent/BlockingQueue/Interrupt.java
> @@ -25,7 +25,6 @@
>  * @test
>  * @bug 6384064
>  * @summary Check proper handling of interrupts
> - * @run main/othervm -XX:-UseVMInterruptibleIO Interrupt
>  * @author Martin Buchholz
>  */
> 
> diff --git a/test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java b/test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java
> --- a/test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java
> +++ b/test/java/util/concurrent/ThreadPoolExecutor/ThrowingTasks.java
> @@ -25,7 +25,6 @@
>  * @test
>  * @bug 6450200 6450205 6450207 6450211
>  * @summary Test proper handling of tasks that terminate abruptly
> - * @run main/othervm -XX:-UseVMInterruptibleIO ThrowingTasks
>  * @author Martin Buchholz
>  */




More information about the core-libs-dev mailing list