JDK 9 RFR of JDK-8035453: Fix serial lint warnings in com.sun.tools and elsewhere

[Paul Sandoz]

Hi Joe,

On Feb 20, 2014, at 10:14 PM, Joe Darcy <joe.darcy at oracle.com> wrote:

> Hello,
> 
> Please review my proposed changes for:
> 
>    JDK-8035453: Fix serial lint warnings in com.sun.tools and elsewhere
>    http://cr.openjdk.java.net/~darcy/8035453.0/webrev/
> 

Looks good.

I agree with Paul B. that it seems a little odd to have to suppress serialization on an abstract class, especially one that implements Serializable (plus Connector.Argument also extends Serializable):


> --- old/src/share/classes/com/sun/tools/jdi/ConnectorImpl.java 2014-02-20 13:03:08.000000000 -0800
> +++ new/src/share/classes/com/sun/tools/jdi/ConnectorImpl.java 2014-02-20 13:03:08.000000000 -0800
> @@ -144,6 +144,7 @@
>         return string;
>     }
> 
> +    @SuppressWarnings("serial") // JDK implementation class
>     abstract class ArgumentImpl implements Connector.Argument, Cloneable, Serializable {
>         private String name;
>         private String label;


Paul.