JDK 9 RFR of JDK-8029561: Optimization in Integer to string conversion

[Joe Darcy]

On 01/02/2014 11:44 AM, Brian Burkhalter wrote:
> Following up from this thread of last week
>
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-December/024162.html
>
> with respect to https://bugs.openjdk.java.net/browse/JDK-8029561.
>
> The change being suggested in this review request is merely to remove the FIXME comment
>
> --- a/src/share/classes/java/lang/Integer.java	Mon Dec 30 16:34:06 2013 +0400
> +++ b/src/share/classes/java/lang/Integer.java	Thu Jan 02 11:21:00 2014 -0800
> @@ -376,9 +376,6 @@
>           // JIT case the dispatch overhead doesn't exist and the
>           // "trick" is considerably faster than the classic code.
>           //
> -        // TODO-FIXME: convert (x * 52429) into the equiv shift-add
> -        // sequence.
> -        //
>           // RE:  Division by Invariant Integers using Multiplication
>           //      T Gralund, P Montgomery
>           //      ACM PLDI 1994
>
> since the code change proposed in the issue report did not show any performance improvement.
>
> Thanks,
>
> Brian

Sounds good to me; thanks,

-Joe