RFR: JDK-8028726 - (prefs) Check src/solaris/native/java/util/FileSystemPreferences.c for JNI pending exceptions

[Chris Hegarty]

On 6 Jan 2014, at 22:29, Dan Xu <dan.xu at oracle.com> wrote:

> Hi All,
> 
> Please review the simple fix for JNI pending exceptions in FileSystemPreferences.c. Thanks!
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8028726
> Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev/

Looks good to me Dan.

Trivially, I don’t think you need the "if (result != null) {“. If the native method “fails” and returns NULL, there will be a pending exception which will be thrown automatically when transitioning back to Java-land. But, what you have is arguably more robust., so thumbs up from me.

-Chris.

> -Dan