8031494: [launcher] java launcher should check for JNI Pending exceptions.

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Mon Jan 13 22:44:46 UTC 2014


As for the launcher helper calls, they all call abort/System.exit and 
bale out,
they are also guarded by ExceptionOccurred in the native-land.

Here is the updated version:

The delta webrev since the last reviewed changes:
http://cr.openjdk.java.net/~ksrini/8031494/webrev.1/webrev.delta/index.html

The full webrev:
http://cr.openjdk.java.net/~ksrini/8031494/webrev.1/

Thanks for the review.
Kumar

> Hi Alan, Chris,
>
>> On 11/01/2014 00:55, Kumar Srinivasan wrote:
>>> Hi,
>>>
>>> Please review fixes for launcher correctness wrt. JNI calls.
>>>
>>> http://cr.openjdk.java.net/~ksrini/8031494/webrev.0/
>> Looks okay, the only thing that isn't clear is whether the calls to 
>> the static methods defined by the launcher helper class can complete 
>> with an exception or not.
>
> The launcher helpers call System.exit via the abort call, however while
> double checking this, I noticed a couple of spots that might need
> these checks. I will post another webrev.
>
> Kumar
>
>>
>> -Alan
>




More information about the core-libs-dev mailing list