RFR: (8030875) Macros for checking and returning on exceptions

David Holmes david.holmes at oracle.com
Tue Jan 14 02:51:46 UTC 2014


Hi Roger,

On 11/01/2014 1:37 AM, roger riggs wrote:
> Please review:
>
> To enable native code checking consistently for thrown exceptions,
> the macros in net_util.h and java/util/jar/pack/coding.cpp are
> made consolidated and promoted to jni_util.h
>
> webrev:
> http://cr.openjdk.java.net/~rriggs/webrev-check-exception-8030875/

Do these macro definitions not cause "empty statement" warnings from the 
compiler? (Existing ones have the same problem I guess)

Also I don't see any use of the CHECK_EXCEPTION macros? In fact the bulk 
of changes here seem completely unrelated to the "exception" aspect of 
this CR.

Cheers,
David

> [1] https://bugs.openjdk.java.net/browse/JDK-8030875



More information about the core-libs-dev mailing list