JDK 9 RFR of JDK-8031651: Remove unneeded -source and -target flags in jdk repo regression tests

Daniel Fuchs daniel.fuchs at oracle.com
Tue Jan 14 11:16:18 UTC 2014


On 1/14/14 2:11 AM, Joe Darcy wrote:
> Hello,
>
> Per the policy set forth in
>
>     JEP 182: Policy for Retiring javac -source and -target Options
> http://openjdk.java.net/jeps/182
>
> in JDK 9, javac will only recognize javac source and target value of 
> 6/1.6 and higher. Therefore, uses of earlier options in the JDK 
> regression tests need to be modified.
>
> Please review the first pass at fixing this before support for the old 
> source and target values is removed:
>
>     JDK-8031651 : Remove unneeded -source and -target flags in jdk 
> repo regression tests
> http://cr.openjdk.java.net/~darcy/8031651.2/
>
> Patch also below.
>
>
[snip]


Hi Joe,

The changes to 
test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java look 
good.

best regards,

-- daniel

> --- 
> old/test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java 
> 2014-01-13 16:54:21.000000000 -0800
> +++ 
> new/test/sun/management/jmxremote/LocalRMIServerSocketFactoryTest.java 
> 2014-01-13 16:54:21.000000000 -0800
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 2008, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 2008, 2014, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -28,7 +28,7 @@
>   *
>   *  @author Daniel Fuchs
>   *
> - *  @run compile -XDignore.symbol.file=true -source 1.6 -g 
> LocalRMIServerSocketFactoryTest.java
> + *  @run compile -XDignore.symbol.file=true -g 
> LocalRMIServerSocketFactoryTest.java
>   *  @run main LocalRMIServerSocketFactoryTest
>   */
>
>




More information about the core-libs-dev mailing list