JDK 9 RFR of 8030814: Long.parseUnsignedLong should throw exception on too large input

Paul Sandoz paul.sandoz at oracle.com
Wed Jan 15 10:56:40 UTC 2014


On Jan 14, 2014, at 8:56 PM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> Please see the updated webrev http://cr.openjdk.java.net/~bpb/8030814/webrev.3/.
> 
> Hopefully my verbose description of the very clever overflow test is accurate and understandable. Also, I cleaned up the JTREG test a bit and added some tests based on the boundary values which split the range of the quantity "guard."
> 

+1 a high comment to code ratio :-) 

I agree with Joe's comments.

Paul.


More information about the core-libs-dev mailing list