JDK9 RFR of JDK-8029646: [pack200] should support the new zip64 format.

[Alexander Zuev]

On 1/15/14 21:34, Xueming Shen wrote:
> On 1/15/14 7:01 AM, Alexander Zuev wrote:
>> Hello,
>>
>>   the new webrev with all the typos and comments fixed can be found 
>> at http://cr.openjdk.java.net/~kizune/8029646/webrev.01/
>>
>> /Alex
>
> (1)  jarmagic can be just a static constant somewhere or a stack 
> variable. not big deal though.
Ok, i'll see to it.
> (2) the test only "tests" EOF for s. there is possibility that the 
> newly created has more extra
>       bytes at the end...though in theory this should not happen, it 
> might be better just add an
>       extra line to check the sizes of two first first?
The test tests for EOF only for s because if s is -1 (EOF) and d is not 
(more extra bytes in newly created jar)
due to the check at line 99 - if (s != d) the exception will be thrown 
for files content mismatch.
> (3) the rest of the change looks good, but I agreed with Kumar that 
> you may need to add a
>       regression test for  a jar file with > 64k entries. otherwise 
> the code for zip64 end  is not
>       being tested. the code looks fine, but I would trust a 
> regression test more than my eyes:-)
All right, i'll modify the regression test.

/Alex